fix GID & UID lookup #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
requested changes
Dec 6, 2016
| @@ -65,8 +65,8 @@ | |||
|
|
|||
| file {$real_file: | |||
| ensure => $ensure, | |||
| owner => $real_user, | |||
| group => $real_group, | |||
| owner => chomp(generate("/usr/bin/id", "-u", $real_user)), | |||
There was a problem hiding this comment.
the generate function will run a command on the puppet master, not on the agent.
|
I don't think this is the correct fix, but the original code does contain a bug I think. https://github.com/voxpupuli/puppet-googleauthenticator/pull/5/files#r91200384 |
|
Agree with @alexjfisher's assessment. @kotowicz would you be interested in replacing your implementation with something that addresses Alex's linked comment? |
|
Hi. Thanks for raising this PR, but I'm going to close it due to inactivity. Please reopen it if you're still interested in getting this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GID is not necessarily the same as UID - invoke '/usr/bin/id' to find out both.
This fixes the following two problems with (non-local) user accounts for me:
Googleauthenticator::User::Systemwide[my-user]/File[/etc/google-authenticator/my-user]/owner) change from root to my-user failed: Could not find user my-user