pam/redhat: use versioncmp function in conditional #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
requested changes
Apr 26, 2021
manifests/pam/redhat.pp
Outdated
| @@ -20,7 +20,7 @@ | |||
|
|
|||
| case $ensure { | |||
| 'present': { | |||
| if ($facts['os']['release']['major'] >= 7) { | |||
| if versioncmp($::facts['os']['release']['major'], '7') > 0 { | |||
There was a problem hiding this comment.
:: for top-level variables isn't needed anymore:
Suggested change
| if versioncmp($::facts['os']['release']['major'], '7') > 0 { | |
| if versioncmp($facts['os']['release']['major'], '7') > 0 { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Use the built-in versioncmp function to check the version of the distribution, otherwise current Puppet installations fail with a type error (cannot compare String with Integer)
This Pull Request (PR) fixes the following issues
see above.