Update readme with examples of using datasource and dashboard #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Nov 26, 2017
README.md
Outdated
| use_ssl => false, | ||
| test_url => '/public/img/grafana_icon.svg', | ||
| require => Class['grafana'], | ||
| } -> |
There was a problem hiding this comment.
puppet-lint will complain about this, can you put '->' in front of 'grafana_dashboard{..' ?
bastelfreak
reviewed
Nov 26, 2017
README.md
Outdated
| use_ssl => false, | ||
| test_url => '/public/img/grafana_icon.svg', | ||
| require => Class['grafana'], | ||
| } -> |
|
Hi @devcfgc, thanks for the PR! Can you take a look at the inline comments I made? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just used the approach described in the issue #35 about using
http_conn_validatorto check if Grafana is up and running before the creation of a Datasource and it took me no time to update the README file with some examples.