Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hdm data types on complex hashes and arrays #3

Merged
merged 4 commits into from
Aug 3, 2022
Merged

Use hdm data types on complex hashes and arrays #3

merged 4 commits into from
Aug 3, 2022

Conversation

tuxmea
Copy link
Member

@tuxmea tuxmea commented Aug 3, 2022

No description provided.

bastelfreak
bastelfreak reviewed Aug 3, 2022
View reviewed changes
manifests/init.pp Outdated Show resolved Hide resolved
rwaffen
rwaffen reviewed Aug 3, 2022
View reviewed changes
Copy link
Sponsor Member

@rwaffen rwaffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tuxmea
several improvements
f00d35d 
bind_ip IP only, without subnet
types with docuementation
@tuxmea tuxmea requested a review from bastelfreak August 3, 2022 12:18
@tuxmea tuxmea merged commit 129f5ff into main Aug 3, 2022
@tuxmea tuxmea deleted the hdm_data_types branch August 3, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwaffen rwaffen rwaffen left review comments

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tuxmea @bastelfreak @rwaffen