Switch version from main to fix version. #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users must check the version to use from hdm website. Updated documentation fixes voxpupuli#52
rwaffen
reviewed
Feb 23, 2023
bastelfreak
reviewed
Feb 23, 2023
bastelfreak
reviewed
Feb 23, 2023
rwaffen
approved these changes
Feb 23, 2023
bastelfreak
approved these changes
Feb 23, 2023
|
Will this break existing setups when the module switches their version from main to 1.0.1? Then we need to add the backwards-incompatible label to the PR. |
|
i dont think so. main and 1.0.1 more or less are the same. main has two merges more, one from dependabot and one for deep-merging if datadir is missing in hiera.yaml. |
|
Looks good to me for issue I raised 👍 |
smortex
reviewed
Feb 23, 2023
tuxmea
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users must check the version to use from hdm website. Updated documentation
fixes #52