Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sles support #75

Merged
merged 1 commit into from
Jan 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,21 +73,18 @@ If you want to install HDM using RVM, you need the following modules:
The [puppetlabs-docker](https://forge.puppet.com/modules/puppetlabs/docker/readme) Module lacks official SLES and SuSe support. Yet: the module is usable on SLES.

The installation of Docker can not be done using the module on SLES.
But one can use any other defined type like `docker::image` or `docker::run`.
Instead one must install Docker separately within a profile class.

One **must** set the `acknowledge_unsupported_os` parameter to `true` and must tell the module to not manage the docker installation.
But any other defined type like `docker::image` or `docker::run` is working.

To allow full functionality, the hdm parameter for `manage_docker` must be set to `true`, as we deactivate this in module data.
One **must** set the `acknowledge_unsupported_os` parameter to `true` to prevent the Docker module from failing on SuSe systems.

Hiera:

```yaml
---
# Allow Docker to work on SLES
docker::acknowledge_unsupported_os: true
docker::manage_package: false
# Enable HDM to use docker module on SLES
hdm::manage_docker: true
```

### Beginning with betadots HDM
Expand Down
2 changes: 0 additions & 2 deletions data/os/Suse.yaml

This file was deleted.

7 changes: 7 additions & 0 deletions metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,13 @@
"18.04",
"20.04"
]
},
{
"operatingsystem": "SLES",
"operatingsystemrelease": [
"12",
"15"
]
}
],
"requirements": [
Expand Down
9 changes: 9 additions & 0 deletions spec/classes/hdm_docker_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,15 @@
'version' => '1.0.1',
}
end
let(:pre_condition) do
if facts[:os]['family'] == 'Suse'
'
class { "docker":
acknowledge_unsupported_os => true,
}
'
end
end

it { is_expected.to compile.with_all_deps }
it { is_expected.to contain_class('docker') }
Expand Down