Extend Hiera 5 template to support trocla backend #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnelson0
reviewed
Nov 30, 2018
rnelson0
reviewed
Nov 30, 2018
templates/hiera.yaml.epp
Outdated
| - "<%= $value %>" | ||
| <%- } -%> | ||
| <%- } -%> | ||
| <%- unless $value =~ Array { -%> |
There was a problem hiding this comment.
I think this should be part of an else clause, as you want one or the other.
m4rx0
force-pushed
the
feature/trocla_support
branch
2 times, most recently
from
00f7262
to
762eeaf
Compare
|
Hi @rnelson0 , |
m4rx0
force-pushed
the
feature/trocla_support
branch
from
762eeaf
to
2c29d5a
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
To be able to configure the custom Hiera backend trocla [1] I had to extend the Hiera 5
hiera.yamltemplate. May there's a better way to do that. So, please let me know.[1] https://github.com/duritong/puppet-trocla#hiera-backend
This Pull Request (PR) fixes the following issues