[dev.icinga.com #12878] Extend attributes fct to parse connected strings

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/12878

Created by lbetz on 2016-10-10 02:14:12 +00:00

Assignee: lbetz
Status: Closed (closed on 2016-10-21 17:06:02 +00:00)
Target Version: v0.6.0
Last Update: 2016-10-21 17:06:02 +00:00 (in Redmine)

---

The attributes function should parse for connected string like:

'ConfigDir + /pki/ + NodeName + .key'

where ConfigDir and NodeName are constants and /pki/ and .key strings. The result should be

ConfigDir + "/pki/" + NodeName + ".key"

[icinga-migration]

Updated by lbetz on 2016-10-11 13:18:53 +00:00

• Done % changed from 0 to 100

... and own attributes of the object are also considered.

[icinga-migration]

Updated by lbetz on 2016-10-11 13:25:40 +00:00

• Done % changed from 100 to 70

Add globals are unquoted. Write a fact for the result of icinga2 console -e 'var res = []; for (k => v in globals) { res.add(k) }; res'

[icinga-migration]

Updated by lbetz on 2016-10-12 11:23:59 +00:00

• Done % changed from 70 to 100

[icinga-migration]

Updated by Reamer on 2016-10-12 18:03:35 +00:00

Why do we need extra facts?
I think, that the puppet manifest keeps care of all files. So Puppet should know which variables are constants. Right?

We have an other problem with this additional facts. The first availability of the constants are with the second run, because icinga isn't installed at the first run and therefore we doesn't have any constant facts. Probably the icinga process will fail to start when puppet triggers the service, because of configuration failures.

If I am wrong let me know.

Greetings Reamer

[icinga-migration]

Updated by lbetz on 2016-10-13 03:39:42 +00:00

• Done % changed from 100 to 90

Arrrrg, your right with the problem of the second run... then we have to put in the code in the params class. At least constants like SysconfDir, ...

[icinga-migration]

Updated by lbetz on 2016-10-13 04:08:40 +00:00

• Done % changed from 90 to 100

Remove the fact and put globals as array in params class.

[icinga-migration]

Updated by lbetz on 2016-10-13 13:34:31 +00:00

merged.

[icinga-migration]

Updated by lbetz on 2016-10-21 17:05:44 +00:00

• Status changed from Assigned to Feedback

[icinga-migration]

Updated by lbetz on 2016-10-21 17:06:02 +00:00

• Status changed from Feedback to Closed