Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authentication configuration #8

Merged
merged 7 commits into from
Apr 7, 2015
Merged

Fix authentication configuration #8

merged 7 commits into from
Apr 7, 2015

Conversation

lazyfrosch
Copy link
Contributor

auth_method => external
Was not handled at all, but provided as defined type.

admin_users => [ list ]
Was written into the wrong ini value

I'll add a few lint fixes soon.

auth_method => external
  Was not handled at all, but provided as defined type.

admin_users => [ list ]
  Was written into the wrong ini value
@arioch
Copy link
Contributor

arioch commented Apr 7, 2015

These are easy to fix...

$ bundle exec rake spec
*snip*
Failures:

  1) icingaweb2 with parameter: admin_users should contain Icingaweb2::Config::Roles[Admins] with role_name =~ /_admin_users_/
     Failure/Error: should contain_icingaweb2__config__roles('Admins').with(
       expected that the catalogue would contain Icingaweb2::Config::Roles[Admins] with role_name set to /_admin_users_/ but it is set to "Admins"
     # ./spec/classes/icingaweb2_spec.rb:58:in `block (3 levels) in <top (required)>'

  2) icingaweb2 with parameter: auth_resource should contain Icingaweb2::Config::Authentication_database[Local Database Authentication] with auth_resource =~ /_auth_resource_/
     Failure/Error: should contain_icingaweb2__config__authentication_database('Local Database Authentication').with(
       expected that the catalogue would contain Icingaweb2::Config::Authentication_database[Local Database Authentication]
     # ./spec/classes/icingaweb2_spec.rb:76:in `block (3 levels) in <top (required)>'

Finished in 8.35 seconds (files took 0.51501 seconds to load)
76 examples, 2 failures, 10 pending

Will you fix those or would you like a pull request?

@lazyfrosch
Copy link
Contributor Author

Yep, working on it.

BTW, I've enabled the Travis builds for that repo...

@arioch
Copy link
Contributor

arioch commented Apr 7, 2015

👍

@lazyfrosch
Copy link
Contributor Author

@arioch would it be okay for you to change the fixtures to HTTPs links?

@arioch
Copy link
Contributor

arioch commented Apr 7, 2015

That would save me the trouble of doing so. 👍

@lazyfrosch
Copy link
Contributor Author

Should be ready for merge :)

@arioch
Copy link
Contributor

arioch commented Apr 7, 2015

Merged upstream!
Thanks Markus.

@icingaadmin icingaadmin merged commit c4d4c0b into voxpupuli:master Apr 7, 2015
@lazyfrosch lazyfrosch deleted the authentication branch April 7, 2015 13:05
bastelfreak pushed a commit to bastelfreak/puppet-icingaweb2 that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants