-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix authentication configuration #8
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auth_method => external Was not handled at all, but provided as defined type. admin_users => [ list ] Was written into the wrong ini value
These are easy to fix...
Will you fix those or would you like a pull request? |
Yep, working on it. BTW, I've enabled the Travis builds for that repo... |
👍 |
@arioch would it be okay for you to change the fixtures to HTTPs links? |
That would save me the trouble of doing so. 👍 |
Should be ready for merge :) |
Merged upstream! |
bastelfreak
pushed a commit
to bastelfreak/puppet-icingaweb2
that referenced
this pull request
Feb 6, 2024
…les for the database client connect]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auth_method => external
Was not handled at all, but provided as defined type.
admin_users => [ list ]
Was written into the wrong ini value
I'll add a few lint fixes soon.