Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Release #966

Closed
jocelynthode opened this issue May 22, 2020 · 8 comments · Fixed by #1060
Closed

New Release #966

jocelynthode opened this issue May 22, 2020 · 8 comments · Fixed by #1060
Milestone

Comments

@jocelynthode
Copy link

Hi,
I see it's been a while since a new release from this module has been released.
Could you please release a new version with the new commits please ?

If a new release is being blocked by something, could you tell what is blocking to see if this is something I can work on, so that we can move forward ?

@ekohl
Copy link
Member

ekohl commented May 22, 2020

Currently the acceptance tests are failing. I've tried to take a look at it, but haven't had a lot of time for it. This is probably related to the CLI and there's a few PRs / issues around that as well. If the acceptance tests are green, I have no problem releasing a new version.

@JohnEricson
Copy link

I agree with this. I just upgraded to the latest released version 1.7.0 of the module for it to work on Puppet 5.5 but I still get the:

Server Error: Evaluation Error: Error while evaluating a Resource Statement, Apt::Source[jenkins]:
  has no parameter named 'key_source' 
  has no parameter named 'include_src'

error. This seems to be fixed in Git master so I will try that one, but it would be really nice if we can get a new release of this module.

@ekohl
Copy link
Member

ekohl commented Aug 30, 2020

#981 at least made the test suite green on Ubuntu in Travis. On a libvirt VM it was also green on CentOS for me. Can't quite explain why yet, but I'd like to have green tests before we release.

I also started with going through some deprecations. However, I'm mostly working on it as a side project so progress is slow. Any help is appreciated.

@ekohl ekohl added this to the 2.0.0 milestone Sep 3, 2020
@ekohl
Copy link
Member

ekohl commented Sep 3, 2020

I've started to assign things to the 2.0.0 milestone.

@evgeni
Copy link
Member

evgeni commented Sep 8, 2020

@ekohl shouldn't it be something higher than 2.0.0? 2.0.0 release exists :)

Anyways, a new release would be really appreciated, as Jenkins changed their signing keys (see e.g. the announcement on https://pkg.jenkins.io/redhat/) to https://pkg.jenkins.io/redhat/jenkins.io.key and the currently released module deploys the old key and then fails to install Jenkins :(

Changing just the key URL in the 2.0.0 release is sufficient to make this work, so maybe a 2.0.1 with that change only is a good intermediate solution? Or picking 67d219e into that release?

@ekohl
Copy link
Member

ekohl commented Sep 8, 2020

Well, it looks like I should have checked more. Looks like I should create a 3.0.0 milestone instead.

@ekohl ekohl modified the milestones: 2.0.0, 3.0.0 Oct 1, 2020
@genebean
Copy link
Contributor

genebean commented Jan 8, 2021

For any following along... #1000 is in progress (a rebase post-merge of other bits of the 3.0.0 milestone will still be needed).

@ekohl ekohl linked a pull request Jan 8, 2021 that will close this issue
@Fabian1976
Copy link

Maybe worth a bump? Could you release a newer version which has the camptocamp/systemd dependency removed (no longer maintained)?

@ekohl ekohl removed a link to a pull request Sep 16, 2022
This was linked to pull requests Sep 16, 2022
@ekohl ekohl removed a link to a pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants