Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow puppetlabs/stdlib 9.x, puppetlabs/java 10.x, puppet/archive 7.x, puppet/zypprepo 5.x, puppet/systemd 6.x #1076

Merged
merged 5 commits into from Sep 5, 2023

Conversation

bastelfreak
Copy link
Member

No description provided.

@bastelfreak bastelfreak added the enhancement New feature or request label Jul 1, 2023
@evgeni evgeni changed the title puppetlabs/stdlib: Allow 9.x puppetlabs/stdlib: Allow 9.x, puppetlabs/java: Allow 10.x Sep 4, 2023
@ekohl
Copy link
Member

ekohl commented Sep 4, 2023

   	Error: Could not install module 'puppetlabs-java' (v10.1.2)
  	  The requested version cannot satisfy one or more of the following installed modules:
  	    puppetlabs-stdlib, installed: 9.3.0, expected: >= 4.13.1 < 10.0.0

I may be blind here, but how does that not satisfy the dependency?

@ekohl
Copy link
Member

ekohl commented Sep 4, 2023

I can't explain it now:

$ pry
[1] pry(main)> require 'semantic_puppet'
=> true
[2] pry(main)> SemanticPuppet::VersionRange.parse(">= 4.13.1 < 10.0.0").include?(SemanticPuppet::Version.parse('9.3.0'))
=> true

@evgeni
Copy link
Member

evgeni commented Sep 5, 2023

[root@da57947e569e /]# puppet module install puppetlabs-stdlib -v 9.3.0
Notice: Preparing to install into /etc/puppetlabs/code/environments/production/modules ...
Notice: Downloading from https://forgeapi.puppet.com ...
Notice: Installing -- do not interrupt ...
/etc/puppetlabs/code/environments/production/modules
└── puppetlabs-stdlib (v9.3.0)
[root@da57947e569e /]# puppet module install puppetlabs-apt -v 9.1.0
Notice: Preparing to install into /etc/puppetlabs/code/environments/production/modules ...
Notice: Downloading from https://forgeapi.puppet.com ...
Notice: Installing -- do not interrupt ...
/etc/puppetlabs/code/environments/production/modules
└─┬ puppetlabs-apt (v9.1.0)
  └── puppetlabs-stdlib (v9.3.0)
[root@da57947e569e /]# puppet module install puppetlabs-java -v 10.1.2 --verbose
Notice: Preparing to install into /etc/puppetlabs/code/environments/production/modules ...
Notice: Downloading from https://forgeapi.puppet.com ...
Info: Resolving dependencies ...
Info: Preparing to install ...
Notice: Installing -- do not interrupt ...
/etc/puppetlabs/code/environments/production/modules
└─┬ puppetlabs-java (v10.1.2)
  ├── puppet-archive (v7.0.0)
  └── puppetlabs-stdlib (v9.3.0)

especially, given this worked…

@evgeni
Copy link
Member

evgeni commented Sep 5, 2023

Ah, but we do not allow archive 7.0… :tableflip:

@evgeni evgeni changed the title puppetlabs/stdlib: Allow 9.x, puppetlabs/java: Allow 10.x Allo puppetlabs/stdlib 9.x, puppetlabs/java 10.x, puppet/archive 7.x Sep 5, 2023
@evgeni evgeni changed the title Allo puppetlabs/stdlib 9.x, puppetlabs/java 10.x, puppet/archive 7.x Allo puppetlabs/stdlib 9.x, puppetlabs/java 10.x, puppet/archive 7.x, puppet/zypprepo 5.x Sep 5, 2023
@evgeni evgeni changed the title Allo puppetlabs/stdlib 9.x, puppetlabs/java 10.x, puppet/archive 7.x, puppet/zypprepo 5.x Allow puppetlabs/stdlib 9.x, puppetlabs/java 10.x, puppet/archive 7.x, puppet/zypprepo 5.x Sep 5, 2023
5.x dropped Puppet 6 support, which we don't support anyway
6.x dropped Ubuntu 18.04 support, which we should drop soon
@evgeni evgeni changed the title Allow puppetlabs/stdlib 9.x, puppetlabs/java 10.x, puppet/archive 7.x, puppet/zypprepo 5.x Allow puppetlabs/stdlib 9.x, puppetlabs/java 10.x, puppet/archive 7.x, puppet/zypprepo 5.x, puppet/systemd 6.x Sep 5, 2023
Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK'ing Tims changes, in the hope he'll ACK mine

@evgeni
Copy link
Member

evgeni commented Sep 5, 2023

I am kinda sure the failures are unrelated, but my motivation to chase them…

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugin failures are certainly a thing this module should address: you need to keep track of all dependencies manually and that changes over time. That causes the tests to fail, quite often.

@ekohl ekohl merged commit 2902a7a into master Sep 5, 2023
3 of 6 checks passed
@ekohl ekohl deleted the stdlib9_20230723 branch September 5, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants