Cloudbees folder patch 1 #1086
Open
Cloudbees folder patch 1 #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the possible slashes in jobname are replaced by underscores to suppress the necessary of existing subfloders in the /tmp folder for temporary file creation
- the possible slashes in jobname are replaced by underscores so the correct file is deleted - the possible slashes in jobname are replaced by '/jobs/' so the correct cloudbees-folder job config file is found and the job is deleted by jenkins api
|
@evgeni what did you do, so the checks have passed? |
|
Fixed up the tests in master and then restarted your PR against that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compatibility with plugin cloudbees-folder'
Pull Request (PR) description
This PR provides the ability to manage elements of type/plugin 'cloudbees-folder'. In this case the name of the job could include slashes for subfolders. So the slashes in the job name have to be replaced by underscore for the temporary created file used for the jenkins api. Also the slashes have to replaced by '/jobs/' for the config.xml of a job while deleting the job via the jenkins api.
This Pull Request (PR) fixes the following issues