Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On slave, add labels and ability to control java version. On master node, add ability to disable the configuration of the firewall. #15

Merged
merged 6 commits into from Aug 8, 2013

Conversation

dcrissman
Copy link
Contributor

There are really three things I am addressing in this pull request.

Slave

  1. Add labels
  2. Add ability to control version of java installed

Master

  1. All for firewall to be disabled in case of conflicting modules

@buildhive
Copy link

Jenkins » puppet-jenkins #17 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@dcrissman
Copy link
Contributor Author

@rtyler This is my re-submittal of #14. In this pull request I attempt to address not only my own issues, but also #5 and #13.

@jenkinsadmin
Copy link

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@matthewbarr
Copy link
Contributor

  1. I'm in favor of the labels.
  2. I'd really prefer to be using an external java module, such as puppetlabs/java, but that's opened as a new issue. I don't think adding this in will hurt anything as it stands. It can be changed in the future.
  3. Sounds like a good idea to allow people to disable. Moving to a configurable port is good. Making it automatically get the port from the config might be better. I can't see why this is a bad first step, though.

matthewbarr added a commit that referenced this pull request Aug 8, 2013
On slave, add labels and ability to control java version. On master node, add ability to disable the configuration of the firewall.
@matthewbarr matthewbarr merged commit 5f6409e into voxpupuli:master Aug 8, 2013
jgreen210 pushed a commit to jgreen210/puppet-jenkins that referenced this pull request Jun 16, 2017
jgreen210 pushed a commit to jgreen210/puppet-jenkins that referenced this pull request Jun 16, 2017
General cleanup and corrections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants