Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract variable to expose for parameterisation of plugins source #555

Closed
wants to merge 3 commits into from
Closed

Conversation

chattr
Copy link

@chattr chattr commented Apr 7, 2016

This is needed so we can continue to use your module alongside our existing infrastructure. Let me know if you have any comments or suggestions. Thanks.

@rtyler
Copy link

rtyler commented Apr 7, 2016

This doesn't look problematic to me, but it is always appreciated to have RSpec Puppet examples introduces with new parameters/features

@chattr
Copy link
Author

chattr commented Apr 7, 2016

Thanks for taking a look so soon. I've had a dig around and found some part of what I think you need:

$ cat jenkins_master_spec.rb
...
let(:params) { { :source => 'https://updates.jenkins-ci.org/download/plugins/swarm/2.0/swarm.hpi' } }
...

That looks incomplete to me; please can you suggest how a complete test might look?

As you've probably guessed by now, I'm not a ruby dev and haven't written ruby tests before, so please bear with me.

@jhoblitt
Copy link
Member

jhoblitt commented Apr 7, 2016

I don't have a strong objection to this but I really don't want to see jenkins::master passing through all of jenkins::plugin's parameters. It isn't very difficult for the end user to replace include ::jenkins::master in the manifest with jenkins::plugin { 'swarm': ... }.

@jenkinsadmin
Copy link

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@bastelfreak
Copy link
Member

Hello. I'm going to close this PR due to inactivity. Please reopen and rebase it if you're still interested in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants