Add support for GoogleRobotPrivateKeyCredentials #861
Conversation
…botPrivateKeyCredentials
files/puppet_helper.groovy
Outdated
| @@ -546,6 +546,10 @@ class Actions { | |||
| throw new UnsupportedCredentialsClass("unsupported " + keyStoreSource) | |||
| } | |||
| break | |||
| case 'com.google.jenkins.plugins.credentials.oauth.GoogleRobotPrivateKeyCredentials': | |||
| info['account_id'] = cred.getServiceAccountConfig().getAccountId() | |||
| info['private_key'] = new String(cred.getServiceAccountConfig().getPrivateKey().getEncoded()) | |||
There was a problem hiding this comment.
Others use IOUtils.toString. As someone not that familiar with groovy, is there a difference?
There was a problem hiding this comment.
TBH I'm not sure either but I'm happy to make that change.
There was a problem hiding this comment.
Maybe some more experienced Jenkins/groovy user could comment on this.
There was a problem hiding this comment.
It looks OK as-is. A literal string is being used to avoid requiring all of those classes to be loaded.
|
I restarted the travis bulid last night after the first failure but it looks like the last build was only 4 hours ago. Was the PR updated with a fix? I want to make sure we're not seeing unstable test behavior. |
|
@jhoblitt, I hasn't updated it since the first commit. I think I need to update the |
|
I've also extended the ``credentials_update_json` method so that we could add credentials of this type. |
|
Thanks for the work @thaiphv ! |
Extends the
credentials_list_jsonmethod in thepuppet_helpers.groovyscript to supportcom.google.jenkins.plugins.credentials.oauth.GoogleRobotPrivateKeyCredentials.