split examples about error and idempotency as much as possible #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Jan 18, 2019
Dan33l
force-pushed
the
split_acceptance_error_idempotency
branch
from
dd7cb99
to
8143669
Compare
bastelfreak
approved these changes
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This module has a large amount of acceptance code. And failing due to error on apply or due to idempotency issue will trigger same message about failure with
works with no errors.The PR try to split as much as possible failing with messages:
works with no errors: when fail is only due to error.works idempotently: when fail is only due to idempotency issue.works with no errors and idempotently: when i was unable to split.This Pull Request (PR) fixes the following issues