Fix issue with detached plugins taking priority. #929
Conversation
As of Jenkins 2.176.2 detached plugins were taking precedence over specified plugins due to a fix that was introduced for docker: https://issues.jenkins-ci.org/browse/JENKINS-57528. The fix in Jenkins ensured stricter processing of plugins. the module was installing plugins as `.hpi` files where Jenkins expects them to be `.jpi` files. This problem was highlighted in voxpupuli#926.
|
@wiccan2 Thanks for the PR. We're also facing the same issue. Hope this change will be merged soon. Any thought about making this change backward compatible ? We're using this module for dozens of customers and they don't necessarily follow jenkins upgrades (core or plugins) thoroughly. This change could then lead to deployment of jpi versions of plugins and I don't really know if this could break stuff. |
|
FWIW, we've faced exactly this issue at Tails and this PR fixed it for us. Thanks! |
| @@ -99,7 +99,7 @@ | |||
| } | |||
|
|
|||
| $plugin_ext = regsubst($download_url, '^.*\.(hpi|jpi)$', '\1') | |||
| $plugin = "${name}.${plugin_ext}" | |||
| $plugin = "${name}.jpi" | |||
There was a problem hiding this comment.
Wouldn't it be better to download the jpi by default on line 97?
There was a problem hiding this comment.
Looks like the update URL still has hpi and this is indeed the correct thing to do.
| } | ||
| $inverse_plugin = "${name}.${inverse_plugin_ext}" | ||
|
|
||
| file {[ |
There was a problem hiding this comment.
Is the code to make sure it's absent still relevant?
|
Dear @wiccan2, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
1 similar comment
|
Dear @wiccan2, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Dear @wiccan2, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Dear @wiccan2, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
I've submitted #957 as an alternative implementation which I believe is simpler. |
|
Closing for inactivity. |
As of Jenkins 2.176.2 detached plugins were taking precedence over specified plugins due to a fix that was introduced for docker: https://issues.jenkins-ci.org/browse/JENKINS-57528.
The fix in Jenkins ensured stricter processing of plugins. the module was installing plugins as
.hpifiles where Jenkins expects them to be.jpifiles.This problem was highlighted in #926.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues