Some improvements to certificate generation #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user provides their own key data then the generation should require it to be in-place before attempting to use it.
bastelfreak
reviewed
Apr 5, 2023
Will now replace invalidate existing certificate information on changes, and replace invalid certificates when necessary
|
I've now successfully verified these changes over multiple installs with both generated and provided secrets |
bastelfreak
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some systems seem to be more particular about their path usage, and also sometimes realize the certification generation chain in slightly odd orders, so more control flow decisions - and the use of the path-fact - seems to be in order.