Fix linting and add some type_aliases #5
Conversation
rwaffen
commented
Feb 23, 2023
rwaffen
commented
- Fix linitng od classes and defines
- Add Types to have shorter class headers
|
sure, will change the names. just took 'em from the variable names. |
|
uff, there are a lot of rubocop recommendations 😓 but i din't touched this, was it like this before? |
| Stdlib::Fqdn, | ||
| Stdlib::IP::Address::Nosubnet, |
There was a problem hiding this comment.
This feels like Stdlib::Host, but isn't quite that. Perhaps stdlib should start using the non-compat IP addresses instead.
These comes in with the module sync. I was thinking about to take care of these later this week or next week |
|
I'd suggest to disable RuboCop in CI until you fix it. voxpupuli/modulesync_config@89c424e should make it easy. That at least gives you unit tests etc. |
|
@ananace had to change it like this, otherwise i couldn't get the tests running again ¯_(ツ)_/¯ you recommended this in #5 (comment) |
| @@ -157,11 +154,7 @@ | |||
|
|
|||
| file { '/etc/sysctl.d/99-k8s.conf': | |||
There was a problem hiding this comment.
for future refrence: we should replace this with our sysctl module
There was a problem hiding this comment.
was thinking of this, but didnt wanted to inflate the pr much more ^^
There was a problem hiding this comment.
I added #7 to keep track of that
| @@ -137,10 +137,7 @@ | |||
|
|
|||
| file { '/etc/modules-load.d/k8s': | |||
| ensure => $ensure, | |||
There was a problem hiding this comment.
for future reference: we should update this with our kmod module.
There was a problem hiding this comment.
#8 is there to keep track
Co-authored-by: Tim Meusel <tim@bastelfreak.de>
|
@rwaffen The comment was more that there were two types with the only difference being that one was Optional, the code as listed here is correct - a.k.a. in this case it should be an empty array I should probably go through and make sure things are more consistent in the use of Optional and default values |
|
I've only done some cursory glances as said, but only got a couple of nitpicks with casing and such left, things that don't necessarily need to be part of this PR |
