Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand use of Sensitive to match node tokens #52

Merged
merged 3 commits into from
Jul 5, 2023
Merged

Expand use of Sensitive to match node tokens #52

merged 3 commits into from
Jul 5, 2023

Conversation

ananace
Copy link
Member

@ananace ananace commented Apr 28, 2023

Fixes #51

@ananace ananace added the bug Something isn't working label Apr 28, 2023
@ananace ananace requested a review from rwaffen April 28, 2023 11:20
rwaffen
rwaffen requested changes Apr 28, 2023
View reviewed changes
Copy link
Sponsor Member

@rwaffen rwaffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but update References pls

@ananace
Copy link
Member Author

ananace commented Apr 28, 2023

@rwaffen Had an old Gemfile.lock on my laptop, so the reference update went in the wrong direction...

@ananace ananace requested a review from rwaffen June 26, 2023 19:58
@ananace ananace merged commit bacc877 into voxpupuli:master Jul 5, 2023
3 checks passed
@ananace ananace deleted the expand-sensitive branch July 5, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak left review comments

@rwaffen rwaffen rwaffen approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bootstrap token is sensitive, node_token is not
3 participants
@ananace @bastelfreak @rwaffen