Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make crictl download url dynamic #54

Merged
merged 1 commit into from
May 5, 2023
Merged

make crictl download url dynamic #54

merged 1 commit into from
May 5, 2023

Conversation

rwaffen
Copy link
Sponsor Member

@rwaffen rwaffen commented May 5, 2023

No description provided.

@bastelfreak bastelfreak self-assigned this May 5, 2023
@bastelfreak bastelfreak added the enhancement New feature or request label May 5, 2023
@bastelfreak bastelfreak merged commit 9aeeaea into voxpupuli:master May 5, 2023
@rwaffen rwaffen deleted the crictl_download_url branch May 5, 2023 08:52
@ananace
Copy link
Member

ananace commented May 5, 2023

There is the k8s::format_url method, which is there specifically to expand URLs for binaries using go-style naming, which would remove the need to specify the arch as an input parameter to the install class.
Additionally, doing variable expansions inside the parameter list like this would remove all functionality from the version/arch parameters - if a user were to actually provide a custom URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bastelfreak bastelfreak

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rwaffen @ananace @bastelfreak