WIP: change broker.id in meta.properties #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change addresses #117: when `broker.id` changes in `server.properties`, this should also be reflected in `$log.dir/meta.properties`. This change will currently allow the broker to startup, should those values have gotten out of sync for which ever reason. However, this will *not* match up leaders/replicas in zookeeper!
|
Hai, can you please add spec tests as well? |
|
@igalic ping |
|
as pointed out by @dhoppe, #117 (comment) this is probably sort of bad idea |
1 similar comment
|
as pointed out by @dhoppe, #117 (comment) this is probably sort of bad idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses #117: when
broker.idchanges inserver.properties, this should also be reflected in$log.dir/meta.properties. This change will currently allow the brokerto startup, should those values have gotten out of sync for which ever
reason.
However, this will not match up leaders/replicas in zookeeper!