release 3.0.0 #134
Merged
release 3.0.0 #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rski
reviewed
Feb 13, 2017
|
|
||
| **Merged pull requests:** | ||
|
|
||
| - release 2.3.0 [\#132](https://github.com/voxpupuli/puppet-kafka/pull/132) ([bastelfreak](https://github.com/bastelfreak)) |
There was a problem hiding this comment.
Apologies @rski. Seems my review and merge went through simultaneous to your review.
IMHO, attritbution should be in a changelog, for the same reason git blame exists (though 'blame' has a negative connotation), historical reference as well as much deserved credit (or blame if it's broke 😈
There was a problem hiding this comment.
For everything else sure, I just find it a bit weird that the release merge for the previous version is under the changelog of the current one.
elmendalerenda
pushed a commit
to elmendalerenda/puppet-kafka
that referenced
this pull request
Mar 30, 2018
release 3.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.