Update default version to 2.4.1 with scala 2.12 #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
force-pushed
the
update_default_version
branch
3 times, most recently
from
519026d
to
a4b6978
Compare
alexjfisher
changed the title
alexjfisher
force-pushed
the
update_default_version
branch
from
a4b6978
to
7f08abf
Compare
bastelfreak
approved these changes
Mar 19, 2020
alexjfisher
force-pushed
the
update_default_version
branch
4 times, most recently
from
94d46bc
to
8c1002a
Compare
alexjfisher
force-pushed
the
update_default_version
branch
9 times, most recently
from
81c08b3
to
4d57c86
Compare
alexjfisher
force-pushed
the
update_default_version
branch
2 times, most recently
from
ac88dc8
to
e210646
Compare
The old versions are no longer downloadable from the default download location. Updating to the latest version is a breaking change.
alexjfisher
force-pushed
the
update_default_version
branch
from
e210646
to
e1845eb
Compare
alexjfisher
changed the title
bastelfreak
reviewed
Mar 25, 2020
| @@ -61,7 +61,7 @@ | |||
| "requirements": [ | |||
| { | |||
| "name": "puppet", | |||
| "version_requirement": ">= 4.10.0 < 6.0.0" | |||
| "version_requirement": ">= 4.10.0 < 7.0.0" | |||
There was a problem hiding this comment.
this should be bumped to 5.5.whatever now?
There was a problem hiding this comment.
For the sake of a separate changelog entry, I was going to do this in a separate PR later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old versions are no longer downloadable from the default download location.
Updating to the latest version is a breaking change.
pgrep -fin init.d was changed due to a 4096 character limitation.Acceptance tests have been fixed up and testing is now also done on CentOS 6.
A lot of the effort was getting the zookeeper module to work.
Tests aren't necessarily that brilliant, (eg. multi-node tests would be better), but at least they pass now.