Support kafka 3.0 topics #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
root-expert
requested changes
Mar 12, 2022
There was a problem hiding this comment.
Hello and thank you for the PR!
Take a look at the inline comments.
Regarding dropping the zookeeper option:
Given that ZooKeeper and bootstrap server are two different subsystems I suggest that we keep both of the options for now. Also, some versions of Kafka that can use zookeeper option are not yet EoL (e.g 2.4.x).
To have one of the two options defined i think it can be achieved with:
if !$zookeeper && !$bootstrap_server {
fail('Either zookeeper or bootstrap_server parameter must be defined!')
}
|
Thanks for the quick replies! I added all the changes, looks better now 🙂 |
root-expert
requested changes
Mar 14, 2022
root-expert
reviewed
Mar 16, 2022
root-expert
approved these changes
Apr 25, 2022
Done! |
|
Thanks for merging and your support! |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
In kafka 3.0 the
--zookeeperoption was removed for topics. It was deprecated in v2.2.0 (March 2019) and--bootstrap-serverhas been available since then. I'm unsure if we should replacezookeeperwithbootstrap-servercompletely or allow both options, but in that case I don't know how to require at least one of both arguments. Open for discussion here.This Pull Request (PR) fixes the following issues
Fixes #302