Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix init script to actually check status #95

Closed

Conversation

fessyfoo
Copy link
Contributor

flip sense of the check that pid in pid file matches pid in process
list.

flip sense of the check that pid in pid file matches pid in process
list.
@igalic
Copy link
Contributor

igalic commented Aug 22, 2016

is this the same as #96 ?

@fessyfoo
Copy link
Contributor Author

#96 was a merge to a different branch. there was some confusion around opentable/puppet-kafka being renamed to voxpupuli/puppet-kafka and the magic redirecting github does.

@fessyfoo
Copy link
Contributor Author

this is a less comprehensive version of #94

@fessyfoo fessyfoo closed this Aug 22, 2016
@fessyfoo fessyfoo mentioned this pull request Aug 22, 2016
@fessyfoo
Copy link
Contributor Author

fessyfoo commented Aug 22, 2016

voxpupli/puppet-kafka was a transfer owner ship of opentable/puppet-kafka and when the branch no-zookeper-dep was pushed to opentable/puppet-kafka it showed up on voxpupli/puppet-kafka which lead to this confusion.

FWIW we reforked opentable/puppet-kafka so we have our own fork again.

blah hope that makes sense, sorry for adding confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants