Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ubuntu to Metadata #175

Closed
nabber00 opened this issue Mar 23, 2019 · 1 comment · Fixed by #188
Closed

Add Ubuntu to Metadata #175

nabber00 opened this issue Mar 23, 2019 · 1 comment · Fixed by #188

Comments

@nabber00
Copy link

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: All
  • Ruby: All
  • Distribution: Ubuntu
  • Module version: 2.0.0

What are you seeing

metadata.json does not include any Ubuntu versions. I am requesting that recent versions be added.

What behaviour did you expect instead

I believe the module is already compatible with Ubuntu since it falls under the "osfamily" fact of Debian which is already implemented. I have tested on 16.04 and 18.04 without issue.
@ekohl
Copy link
Member

ekohl commented Mar 23, 2019

Would you be willing to work on a patch? Ideally also adding acceptance tests since that's the best way to prove it works and doesn't regress.

alexjfisher added a commit to alexjfisher/puppet-keepalived that referenced this issue Jul 20, 2019
@alexjfisher
Add Ubuntu to list of supported OSes
a48526a 
Fixes voxpupuli#175
@alexjfisher alexjfisher mentioned this issue Jul 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Ubuntu 16.04 and 18.04 to list of supported OSes alexjfisher/puppet-keepalived
2 participants
@ekohl @nabber00