Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Keepalived::Vrrp::Instance::VRule syntax #200

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Fix Keepalived::Vrrp::Instance::VRule syntax #200

merged 1 commit into from
Nov 20, 2019

Conversation

cocker-cc
Copy link
Contributor

Pull Request (PR) description

Set curly Braces in Type-Definition as stated in Puppet-Documentation.

This Pull Request (PR) fixes the following issues

Puppet-Parser 4.10.12 complains with "Syntax error at '=>'", whereas
Puppet-Parser 6.2 and 6.4 don't...
However Puppet-Documentation states, that curly Braces have to be there.

Puppet-Parser 4.10.12 complains with "Syntax error at '=>'", whereas
Puppet-Parser 6.2 and 6.4 don't...
However Puppet-Documentation states, that curly Braces have to be there.
@alexjfisher alexjfisher changed the title Fix Syntax-Error Fix Keepalived::Vrrp::Instance::VRule syntax Nov 20, 2019
@alexjfisher
Copy link
Member

Not sure why puppet 5/6 are allowing this, and even though we don't support puppet 4, this change is correct according to https://puppet.com/docs/puppet/latest/lang_data_abstract.html#the-struct-data-type

@alexjfisher alexjfisher added the bug Something isn't working label Nov 20, 2019
@alexjfisher
Copy link
Member

@cocker-cc Thanks!

@alexjfisher alexjfisher merged commit f47b59f into voxpupuli:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants