make unicast-peer resource-name unique by adding the instance-name

[unki]

Considering the following 3-node-setup:

Node	IP
node1	10.0.0.1
node2	10.0.0.2
node3	10.0.0.3

There are two different VIPs bound to two separate VRRP-instances

• instance1, VIP primarily held by node1
• instance2, VIP primarily held by node2.

Both instances share the same unicast-peers - like in below config-snippet from node1 (10.0.0.1).

keepalived::vrrp_instance:
  instance1:
    unicast_peers:
      - 10.0.0.2
      - 10.0.0.3
  instance2:
    unicast_peers:
      - 10.0.0.2
      - 10.0.0.3

That was a working config before - but by introducing the keepalived::vrrp::unicast_peer type in #227 this now fails as duplicate keepalived::vrrp::unicast_peer resources would get created with the same resource-names.

Therefor I would like to suggest binding the resource-name to the VRRP-instance.
Either by just looping over $unicast_peer_array like I've done in this PR.
Or in any other way.

[bastelfreak]

looks good to me. I will keep this open in case someone else want's to review this and knows more about keepalived

[fklajn]

Any chance that this will be merged and released soon?

[kenyon]

Any chance that this will be merged and released soon?

@fklajn have you tested this change, and does it work for you?

[fklajn]

Yes, it works for me. I had to fork the repo and for now I am using my own copy with cherry-picked change. It would be nice to have this in upstream.

[unki]

Yes, it works for me. I had to fork the repo and for now I am using my own copy with cherry-picked change. It would be nice to have this in upstream.

Can ack this too. We are using it in prod since I've opened this PR.