Avoid messing up fragment ordering if instance name contains dashes #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess the Ubuntu 22.04 test failure is related, not sure why though. |
|
I don't see how those could be related to my changes. All I can see in the test output is
I also don't see any way for me to debug this. Other tests show the contents of keepalived.conf before starting it, but the Ubuntu tests don't. 🤷🏻♂️ |
|
BTW, the same tests also fail with the same error in PR #299 |
|
While deploying to our environment today I noticed, that unicast_peers was not working. The second commit fixes that. However, it will not fix the Ubuntu checks. Those have been broken since Ubuntu 22.04 support was added with PR #297. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Config fragments are called 100-$NAME-key (Note: parts are separated by dashes). Now if the following conditions are met, ordering will be messed up:
I created another "ordersafe" variable that does not contain dashes. Also I noticed that $_name could still contain colons, slashes, ... because regsubst was just removing the first occurrence. The G flag will fix this, while we're here.
This Pull Request (PR) fixes the following issues
Fixes #302