Gentoo/Debian: Enable hasstatus for service #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The services are deployed as proper systemd services on all OSes. When hasstatus is true, Puppet will use systemctl to check if the service is running. If it's false, Puppet will try to grep within `ps` for the service. That's unreliable and doesn't make any sense. See: https://www.puppet.com/docs/puppet/8/types/service.html#service-description it's not clear why this ever was introduced: voxpupuli@ace4ed6
rwaffen
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The services are deployed as proper systemd services on all OSes. When hasstatus is true, Puppet will use systemctl to check if the service is running. If it's false, Puppet will try to grep within
psfor the service. That's unreliable and doesn't make any sense. See: https://www.puppet.com/docs/puppet/8/types/service.html#service-descriptionit's not clear why this ever was introduced: ace4ed6
Pull Request (PR) description
This Pull Request (PR) fixes the following issues