Crossport hash.rb from elastic/puppet-elasticsearch

[baurmatt]

hash.rb is also used in elastic/puppet-elasticsearch. The files are
currently not the same which leads to environment leaking errors due to
the module being a PuppetX function.

This copies the content of the file form elastic/puppet-elasticsearch to
get around the environment leaking for now.

Pull request acceptance prerequisites:

• Signed the CLA (if not already signed)
• Rebased/up-to-date with base branch
• Updated CHANGELOG.md with patch notes (if necessary)
• Any relevant docs (README.markdown or inline documentation) updated (if necessary)
• Updated CONTRIBUTORS (if you would like attribution)
• Tests pass CI

[baurmatt]

Tried for hours - can't reproduce the issue in Travis CI. I'm pretty sure that it isn't related to this PR.

[yakirgb]

Thank you @baurmatt, i have same issue:

~/git/puppet/modules/common_v2$ ag lib/puppet_x/elastic/hash.rb
kibana/checksums.json
17:  "lib/puppet_x/elastic/hash.rb": "159abda7275f5bc45f354ce4fc59cce9",

elasticsearch/checksums.json
90:  "lib/puppet_x/elastic/hash.rb": "4300b3a1327121c196bc7c02e51055e4",

And every puppet run the file changing to 159abda7275f5bc45f354ce4fc59cce9 or 4300b3a1327121c196bc7c02e51055e4

[yakirgb]

@tylerjl can you check the CI please ?

[yakirgb]

@tylerjl @mmoll can you merge please?

[mmoll]

I don't have merge permissions here... also, tests fail (probably not related to this PR).

[tajehn]

Sorry but I have no clue about what this is about? Br Thomas

…

On Mon, 30 Mar 2020, 14:21 Michael Moll, ***@***.***> wrote: I don't have merge permissions here... also, tests fail (probably not related to this PR). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#41 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AL6IS67BEUZKN6VU75LA7XLRKCFFFANCNFSM4KWSFPIA> .

[baurmatt]

Hey @fatmcgav, I've seen you doing a lot of work at puppet-elasticsearch. Any chance you could take a look at this?

Thank you! :)

[sboyd-m]

Any chance this can get a push to see if its still viable? This is an issue for us as well, very sad to see it take over 2 years to copy a file, is there a way to help move this along?

[kenyon]

Rebasing on current master would be a good start.

[baurmatt]

Sure! :) Looking forward to get this finally merged! :)

[smortex]

LGTM