Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation/examples for certonly suppress_cron_output not updated after removal of parameter #302

Closed
cFire opened this issue Dec 2, 2022 · 1 comment · Fixed by #303

Comments

@cFire
Copy link
Contributor

cFire commented Dec 2, 2022

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 7.20.0
  • Ruby: 2.7.6p219
  • Distribution: Debian 11
  • Module version: 9.0.0

How to reproduce (e.g Puppet code you use)

letsencrypt::certonly { "LE_${user}_${domain}":
  ensure              => $ensure_default,
  manage_cron         => true,
  domains             => $domains,
  plugin              => 'apache',
  supress_cron_output => true,
}

What are you seeing

The above code is still correct according to documentation/examples but of course now produces an error when applying:
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Letsencrypt::Certonly[LE_redacted_redacted]: has no parameter named 'suppress_cron_output' (file: /etc/puppetlabs/code/environments/production/modules/site_apache/manifests/vhost/user.pp, line: 74) on node host.example.com.

It seems the suppress_cron_output parameter was removed in f6a6a4e in favor of the cron_output parameter which has the suppress option to replace the functionality. Documentation and example code was not updated to reflect these changes.

treydock added a commit to treydock/puppet-letsencrypt that referenced this issue Dec 2, 2022
@treydock
Copy link
Contributor

treydock commented Dec 2, 2022

@cFire The fix is in #303. Not sure how that got missed during the release process. That's the only place I could find a reference to the old parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants