Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CentOS 8 support #313

Merged
merged 1 commit into from Apr 4, 2023
Merged

Add CentOS 8 support #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion metadata.json
View file
Open in desktop
Expand Up @@ -23,7 +23,8 @@
{
"operatingsystem": "CentOS",
"operatingsystemrelease": [
"7"
"7",
"8"
]
},
{
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/plugin/dns_rfc2136_spec.rb
View file
Open in desktop
Expand Up @@ -19,7 +19,7 @@ class { 'letsencrypt':
osrelease = facts[:os]['release']['major']
osfull = "#{osname}-#{osrelease}"
case osfull
when 'Debian-10', 'Debian-11', 'AlmaLinux-8', 'RedHat-8', 'Ubuntu-22.04', 'Ubuntu-20.04', 'Ubuntu-18.04', 'Fedora-36', 'Rocky-8'
when 'Debian-10', 'Debian-11', 'AlmaLinux-8', 'RedHat-8', 'Ubuntu-22.04', 'Ubuntu-20.04', 'Ubuntu-18.04', 'Fedora-36', 'Rocky-8', 'CentOS-8'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evgeni it looks like the package doesn't exist on openbsd. because of that we don't set the variable for openbsd. in line 48 we check if package_name is empty. So we cannot set python3-certbot-dns-rfc2136 as default :(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

'python3-certbot-dns-rfc2136'
when 'RedHat-7', 'CentOS-7'
'python2-certbot-dns-rfc2136'
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/plugin/dns_route53_spec.rb
View file
Open in desktop
Expand Up @@ -19,7 +19,7 @@ class { 'letsencrypt':
osrelease = facts[:os]['release']['major']
osfull = "#{osname}-#{osrelease}"
case osfull
when 'Debian-10', 'Debian-11', 'AlmaLinux-8', 'RedHat-8', 'Ubuntu-22.04', 'Ubuntu-20.04', 'Ubuntu-18.04', 'Fedora-36', 'Rocky-8'
when 'Debian-10', 'Debian-11', 'AlmaLinux-8', 'RedHat-8', 'Ubuntu-22.04', 'Ubuntu-20.04', 'Ubuntu-18.04', 'Fedora-36', 'Rocky-8', 'CentOS-8'
'python3-certbot-dns-route53'
when 'RedHat-7', 'CentOS-7'
'python2-certbot-dns-route53'
Expand Down