Add cron_before_command #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm... I suppose we should remove tests for ruby 1.9.3(because of json_pure) and puppet 3.4.0(because of https://tickets.puppetlabs.com/browse/PUP-1597). @danzilio r? |
|
Hi @gkopylov, sorry about the delay on this. Could you rebase this PR and we can see where it's at? |
|
@danzilio ok, done. |
|
@gkopylov More merge conflicts |
|
@juniorsysadmin done. |
juniorsysadmin
approved these changes
Jan 1, 2017
jethrocarr
pushed a commit
to jethrocarr/puppet-letsencrypt
that referenced
this pull request
Jan 29, 2017
* Add cron_before_command * Fix lint errors * Fix rubocop offenses
cegeka-jenkins
pushed a commit
to cegeka/puppet-letsencrypt
that referenced
this pull request
Oct 23, 2017
* Add cron_before_command * Fix lint errors * Fix rubocop offenses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you use 80 port for your web app and letsencrypt start updating it show the error that 80 port already bound to another app. So we need to stop nginx for example(or another web service) to allow letsencrypt to update.