Merge pull request #17 from scalefactory/start_with_blank_line_Fix

Fix issue with blank line at the beginning of a file.
voxpupuli · Feb 7, 2019 · f4c0056 · f4c0056
2 parents f018c92 + d22a4b7
commit f4c0056
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/lib/puppet-lint/plugins/check_strict_indent.rb b/lib/puppet-lint/plugins/check_strict_indent.rb
@@ -131,9 +131,9 @@ def check
       actual = 0
       if token.next_token.type == :INDENT
         actual = token.next_token.value.length
-      elsif token.prev_token.type == :HEREDOC
+      elsif !token.prev_token.nil? and token.prev_token.type == :HEREDOC
         actual = token.prev_token.value.split("\n").last.length
-      elsif token.prev_token.type == :HEREDOC_OPEN
+      elsif !token.prev_token.nil? and token.prev_token.type == :HEREDOC_OPEN
         actual = next_token.prev_token.value.split("\n").last.length
       else
         actual = 0

diff --git a/spec/puppet-lint/plugins/check_strict_indent_spec.rb b/spec/puppet-lint/plugins/check_strict_indent_spec.rb
@@ -77,4 +77,17 @@ class (
       expect(problems).to have(1).problems
     end
   end
+
+  context 'blank line at beginning of file' do
+    let(:code) {
+      <<-EOF.gsub(/^ {8}/, '')
+
+        class () {}
+      EOF
+    }
+
+    it 'should detect 0 problems' do
+      expect(problems).to have(0).problems
+    end
+  end
 end