rubocop: autofix

.rubocop.yml

@@ -1,4 +1,6 @@
 ---
+inherit_from: .rubocop_todo.yml
+
 # Managed by modulesync - DO NOT EDIT
 # https://voxpupuli.org/docs/updating-files-managed-with-modulesync/
 

.rubocop_todo.yml

@@ -0,0 +1,54 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2023-04-21 15:31:06 UTC using RuboCop version 1.50.2.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Configuration parameters: ForbiddenDelimiters.
+# ForbiddenDelimiters: (?i-mx:(^|\s)(EO[A-Z]{1}|END)(\s|$))
+Naming/HeredocDelimiterNaming:
+  Exclude:
+    - 'puppet-lint-variable_contains_upcase.gemspec'
+
+# Offense count: 6
+# Configuration parameters: Prefixes, AllowedPatterns.
+# Prefixes: when, with, without
+RSpec/ContextWording:
+  Exclude:
+    - 'spec/puppet-lint/plugins/variable_contains_upcase_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: IgnoredMetadata.
+RSpec/DescribeClass:
+  Exclude:
+    - '**/spec/features/**/*'
+    - '**/spec/requests/**/*'
+    - '**/spec/routing/**/*'
+    - '**/spec/system/**/*'
+    - '**/spec/views/**/*'
+    - 'spec/puppet-lint/plugins/variable_contains_upcase_spec.rb'
+
+# Offense count: 2
+RSpec/RepeatedExampleGroupDescription:
+  Exclude:
+    - 'spec/puppet-lint/plugins/variable_contains_upcase_spec.rb'
+
+# Offense count: 5
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, always_true, never
+Style/FrozenStringLiteralComment:
+  Exclude:
+    - 'Gemfile'
+    - 'Rakefile'
+    - 'lib/puppet-lint/plugins/variable_contains_upcase.rb'
+    - 'puppet-lint-variable_contains_upcase.gemspec'
+    - 'spec/puppet-lint/plugins/variable_contains_upcase_spec.rb'
+
+# Offense count: 1
+Style/MultilineBlockChain:
+  Exclude:
+    - 'lib/puppet-lint/plugins/variable_contains_upcase.rb'

lib/puppet-lint/plugins/variable_contains_upcase.rb

@@ -1,18 +1,19 @@
 PuppetLint.new_check(:variable_contains_upcase) do
   def check
-    tokens.select { |r|
+    tokens.select do |r|
       Set[:VARIABLE, :UNENC_VARIABLE].include? r.type
-    }.each do |token|
-      if token.value.gsub(/\[.+?\]/, '').match(/[A-Z]/)
-        notify :warning, {
-          :message => 'variable contains a capital letter',
-          :line    => token.line,
-          :column  => token.column,
-          :token   => token,
-        }
-      end
+    end.each do |token|
+      next unless /[A-Z]/.match?(token.value.gsub(/\[.+?\]/, ''))
+
+      notify :warning, {
+        message: 'variable contains a capital letter',
+        line: token.line,
+        column: token.column,
+        token: token,
+      }
     end
   end
+
   def fix(problem)
     problem[:token].value.downcase!
   end

puppet-lint-variable_contains_upcase.gemspec

@@ -1,5 +1,5 @@
 Gem::Specification.new do |spec|
-  spec.name        = 'puppet-lint-variable_contains_upcase'
+  spec.name = 'puppet-lint-variable_contains_upcase'
   spec.version     = '1.4.0'
   spec.homepage    = 'https://github.com/fiddyspence/puppetlint-variablecase'
   spec.license     = 'MIT'
@@ -11,18 +11,12 @@ Gem::Specification.new do |spec|
     'lib/**/*',
     'spec/**/*',
   ]
-  spec.test_files  = Dir['spec/**/*']
   spec.summary     = 'puppet-lint variable_case check'
   spec.description = <<-EOF
     Extends puppet-lint to ensure that your variables are all lower case
   EOF
 
   spec.required_ruby_version = '>= 2.7.0'
 
-  spec.add_dependency             'puppet-lint', '>= 3', '< 5'
-  spec.add_development_dependency 'rspec', '~> 3.0'
-  spec.add_development_dependency 'rspec-its', '~> 1.0'
-  spec.add_development_dependency 'rspec-collection_matchers', '~> 1.0'
-  spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'rspec-json_expectations'
+  spec.add_dependency 'puppet-lint', '>= 3', '< 5'
 end

spec/puppet-lint/plugins/variable_contains_upcase_spec.rb

@@ -6,23 +6,23 @@
   context 'a variable containing a capital' do
     let(:code) { '$fOobar' }
 
-    it 'should only detect a single problem' do
+    it 'onlies detect a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create a warning' do
+    it 'creates a warning' do
       expect(problems).to contain_warning(msg).on_line(1).in_column(1)
     end
   end
 
   context 'variable containing a capital' do
     let(:code) { '" $fOobar"' }
 
-    it 'should only detect a single problem' do
+    it 'onlies detect a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create a warning' do
+    it 'creates a warning' do
       expect(problems).to contain_warning(msg).on_line(1).in_column(3)
     end
   end
@@ -39,37 +39,39 @@
     context 'fix variable containing a capital' do
       let(:code) { '" $fOobar"' }
 
-      it 'should only detect a single problem' do
+      it 'onlies detect a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(3)
       end
 
-      it 'should downcase the variable name' do
+      it 'downcases the variable name' do
         expect(manifest).to eq('" $foobar"')
       end
     end
 
     context 'a hash with an upcase key should not fail' do
       let(:code) { ' $myhash["Foo"]' }
 
-      it 'should not detect a single problem' do
+      it 'does not detect a single problem' do
         expect(problems).to have(0).problem
       end
     end
+
     context 'a hash with an upcase key should not fail' do
       let(:code) { ' $myhash["Foo"]["bAr"]' }
 
-      it 'should not detect a single problem' do
+      it 'does not detect a single problem' do
         expect(problems).to have(0).problem
       end
     end
+
     context 'a hash variable with an upcase key should fail' do
       let(:code) { ' $myHash["foo"]["bar"]' }
 
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
     end