Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the creation of default [bw]tmp-rulesets configurable #65

Merged
merged 1 commit into from Dec 11, 2017

Conversation

mcgege
Copy link

@mcgege mcgege commented Jun 2, 2017

As I'm configuring the rules for btmp and wtmp on my own, the default rulesets conflict with my rules.
With this change you can disable the generation of the default rules like this:

class { '::logrotate':
  defaultrule_bwtmp => false,
}

@juniorsysadmin juniorsysadmin added enhancement New feature or request needs-rebase labels Dec 6, 2017
@juniorsysadmin
Copy link
Member

@mcgege This PR needs a rebase. Are you still interested in merging this?

@mcgege
Copy link
Author

mcgege commented Dec 6, 2017

@juniorsysadmin Sure I am ... will do this the next days

@mcgege
Copy link
Author

mcgege commented Dec 9, 2017

@juniorsysadmin I have now rewritten the patch and expanded the switch to disable all base rules (although the base rules still contain only rules for btmp and wtmp - but this might change in the future). Therefore the parameter name also changed:

class { '::logrotate':
  create_base_rules => false,
}

@juniorsysadmin
Copy link
Member

@mcgege Thanks for this. Are you able to add some appropriate puppet-rspec tests as well?

@mcgege
Copy link
Author

mcgege commented Dec 10, 2017

@juniorsysadmin I hope that's what you expected - my first try in rspec :-)
There should also be a section in the readme to document these global settings ...

@juniorsysadmin juniorsysadmin merged commit 610febf into voxpupuli:master Dec 11, 2017
@mcgege mcgege deleted the conf-wbtmp branch December 11, 2017 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants