Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release to PuppetForge #8

Merged
merged 5 commits into from Apr 24, 2017
Merged

Release to PuppetForge #8

merged 5 commits into from Apr 24, 2017

Conversation

ppanero
Copy link
Collaborator

@ppanero ppanero commented Apr 24, 2017

Tag bump for release
Changelog created

@traylenator
Copy link
Collaborator

@ppanero has no permission to tag so once merged a tag will need to be added as things stand.

metadata.json Outdated
{"name":"puppetlabs-vcsrepo","version_requirement":">= 1.3.2 < 2.0.0"}
{
"name": "puppetlabs-stdlib",
"version_requirement": ">= 1.0.0 < 5.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please bump the 1.0.0 to 4.13.1. That is the first version that works properly with puppet 4

@bastelfreak
Copy link
Member

our rake task, that every collaborator can execute, will automatically create the tag.

metadata.json Outdated
@@ -1,15 +1,21 @@
{
"name": "puppet-misp",
"version": "0.2.0",
"version": "0.2.3-rc0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump it to the next version. I guess that will be 0.2.2 (thats mentioned in the CHANGELOG.md)? Please don't add the -rc0.

Copy link
Collaborator Author

@ppanero ppanero Apr 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was done by the travis_release. I understood that I could executre the rake but its true I didnt have permsisions.

@bastelfreak
Copy link
Member

Please also add a version requirement for Puppet to the metadata.json:

  "requirements": [
    {
      "name": "puppet",
      "version_requirement": ">= 4.6.1 < 5.0.0"
    }
  ]

@bastelfreak
Copy link
Member

ah okay. You have to update the changelog + bump the version in the metadata.json to the desired one. after that I will merge the PR and execute the rake task. this will create the tag + bump the version afterwards, to -rc0. We have a check implemented that prevents us from releasing -rc0 versions.

@ppanero
Copy link
Collaborator Author

ppanero commented Apr 24, 2017

@bastelfreak Updated with puppet version requirement. Tho we want to accept 3.8.

@bastelfreak bastelfreak merged commit edb8479 into voxpupuli:master Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants