Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update keywords, functions and metaparameters #106

Merged
merged 1 commit into from Dec 20, 2017
Merged

Update keywords, functions and metaparameters #106

merged 1 commit into from Dec 20, 2017

Conversation

paran1
Copy link
Contributor

@paran1 paran1 commented Nov 12, 2017

Update keywords, functions and metaparameters for the latest version
of Puppet which is 5.3.

Fixes #74

Update keywords, functions and metaparameters
916b963 
Update keywords, functions and metaparameters for the latest version
of Puppet which is 5.3.
@paran1 paran1 mentioned this pull request Nov 14, 2017
Closed
vinzent
vinzent reviewed Dec 20, 2017
View reviewed changes
Copy link
Contributor

@vinzent vinzent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paran1 whats the problem wuth the failing test?

otherwise looks good to me

@paran1
Copy link
Contributor Author

paran1 commented Dec 20, 2017

@vinzent the failing tests is a false positive, I opened #109 about that. Basically, Travis seems to frequently fail while installing elpa/melpa packages. Should be possible to just restart the test for somebody with access.

vinzent
vinzent approved these changes Dec 20, 2017
View reviewed changes
Copy link
Contributor

@vinzent vinzent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restarted tests are green now

@vinzent vinzent merged commit 7a551bb into voxpupuli:master Dec 20, 2017
@paran1 paran1 deleted the update-keywords branch December 20, 2017 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinzent vinzent vinzent approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paran1 @vinzent