Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try using vagrant #50

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

try using vagrant #50

wants to merge 1 commit into from

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Jan 22, 2024

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

with:
pidfile_workaround: 'false'
beaker_hypervisor: vagrant
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be libvirt?

Suggested change
beaker_hypervisor: vagrant
beaker_hypervisor: vagrant_libvirt

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. The Beaker hypervisor is Vagrant. Which hypervisor vagrant then uses is a different beast. ;)

(hypervisors all the way down)

Copy link
Member Author

@evgeni evgeni Jan 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and I won't go down the rabbithole that libvirt can use different backends, besides qemu, but vagrant-libvirt really only knows about qemu)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's surprising, because I have:

$ env | grep BEAKER
BEAKER_HYPERVISOR=vagrant_libvirt

@kenyon
Copy link
Member

kenyon commented Jan 22, 2024

If you can get this working, I think running tests with vagrant VMs instead of docker will help fix tests for https://github.com/voxpupuli/puppet-chrony and https://github.com/voxpupuli/puppet-rsyslog/ and maybe others.

@evgeni
Copy link
Member Author

evgeni commented Jan 22, 2024

This PR was mostly a playground for voxpupuli/gha-puppet#49, but yes this can be useful for a couple of modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants