Add new rhnget options
#44
Conversation
Add `rhnget_cleanup` and `rhnget_download_all` parameters
|
@matonb Thanks for your PR. I've incorporated your change into this new rebased PR and added some tests. Does this look ok to you? |
| @@ -140,6 +152,12 @@ | |||
| validate_re($rhn_password, '.+') | |||
| } | |||
|
|
|||
| if $rhnget_cleanup != undef { | |||
There was a problem hiding this comment.
This could be rebased to be if $rhnget_cleanup
There was a problem hiding this comment.
no, as this is a boolean if not undef
There was a problem hiding this comment.
Maybe I take that back. I suppose if it is false there's no real need to hit the validate_bool. But it might be safer to leave as is in case any other code is ever added to the if block?
There was a problem hiding this comment.
It'll also catch any bits where I've already used 'yes' / 'no' in a manifest
| validate_bool($rhnget_cleanup) | ||
| } | ||
| if $rhnget_download_all != undef { | ||
| validate_bool($rhnget_download_all) |
There was a problem hiding this comment.
This could be rebased to be if $rhnget_download_all
| @@ -140,6 +152,12 @@ | |||
| validate_re($rhn_password, '.+') | |||
| } | |||
|
|
|||
| if $rhnget_cleanup != undef { | |||
|
@alexjfisher 👍 Looks fine to me ( but I am having another squinty day today ) |
Rebase of #36 plus additional commit with tests.