Manage iso directory within mrepo::iso (requires puppet/archive, drop puppet/staging) #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previsouly the directory, where iso file are downloaded to, was not managed by the define mrepo::iso, which is not expected behaviour. This change adds a file resource for the download directory.
bastelfreak
reviewed
Oct 20, 2018
manifests/iso.pp
Outdated
| mode => "0644", | ||
| } | ||
|
|
||
| -> staging::file { $name: |
There was a problem hiding this comment.
The staging module is deprecated. Could you implement this with https://forge.puppet.com/puppet/archive ?
There was a problem hiding this comment.
ah, the diff trolled me, that was already present. You don't need to rework this (unless you want to).
|
@mrolli can you take a look at the failing travis jobs and add a unit test for this change? |
|
Hm, apparently the rubocop ruleset of voxpupuli differs a lot with what Puppetlabs is using in PDK. :-( Is this: really better than this?: Anyway, fixed to fit the voxpupuli standards. |
bastelfreak
changed the title
|
Thanks @mrolli ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Previsouly the directory, where iso file are downloaded to, was not
managed by the define mrepo::iso though blindly used, which is not expected behaviour. This
change adds a file resource for the download directory.
This Pull Request (PR) fixes the following issues
n/a