Setup routes a CIDR, not full subnetmask #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oniGino
force-pushed
the
fix_centos_route
branch
14 times, most recently
from
bca55dc
to
a3e7c2c
Compare
- Fix Style issues - Keep full mask in route structure to pass tests but use prefix when writing file Signed-off-by: Gino <onigino@protonmail.com>
bastelfreak
changed the title
|
Hi @oniGino, thanks for fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Fix Broken Redhat network_route module
broken against centos7 and centos8 (not testing on 6)
This Pull Request (PR) fixes the following issues
Fixes #169
Fixes #209
Fixes #281
Fixes #218 (i merged these tests into this PR)