Declare support for RHEL9, CentOS9 and OL9 #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbarrientos
changed the title
If 'networking' is not removed from the facts, the values declared in `default_module_facts.yml` win (the fact set contains two keys: `:networking` and `'networking'`) This test has always been wrong as the interfaces were never been mocked and the asserts were based on the contents on the default module facts, not the test context itself. The bug is obvious in the Puppet6/CentOS9 combination as there's no `networking` fact in FacterDB, hence only in that case the fact is overridden and the test does not pass (as it shouldn't). This fix makes sure that the fact set in the test context is correct and also that the test declares the actually expected resources.
traylenator
approved these changes
Feb 8, 2022
keachi
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patchset also fixes a test that only started to (rightfully) fail when Puppet6+CentOS9 was added to the test matrix. See the commit message for more details.