-
-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What's the correct way to set config options now? #978
Comments
Hi @chriskuehl @jvperrin Yes, things are in a bit of a state of transition, the next release will get rid of the public As for earlier versions, including current Forge release, most of the parameters that relate to the module itself are in |
Is there an ETA for the next release? |
We're hoping to actually just cut a long-overdue 1.x. However, may need to do one or two additional fixes before we release it. Hope that answers everyone's questions; I'm going to close this one now, as I think the original question has been answered. |
First, thanks a lot for maintaining this module!
I'd like to ask about the current best practice for declaring parameters. We're using the latest (0.5.0) version of this module. Currently, we're doing something like this:
This works okay but we always get a warning:
Additionally, we can only declare this class once, which is sometimes inconvenient (even though we always use the same parameters).
The link no longer works, but for reference, here's an older version: https://github.com/voxpupuli/puppet-nginx/blob/163556f769eb39e33b2592a504c9da2634b52b32/docs/hiera.md
It looks like there's been a recent change to the way these config parameters are set in #950 and I'm having trouble determining the recommended best practice for setting these now. Originally I tried following the advice from the now-deleted
hiera.md
docs:...but some of these parameters didn't work (
manage_repo
andpackage_name
), which makes sense looking at https://github.com/voxpupuli/puppet-nginx/blob/621778d4b5c2f9dffa4aa1bffc8db317a4cb63b8/manifests/config.pp.From looking through the code, it looks like we can set these on
nginx::package
instead, but that didn't work either, so I think I might be approaching this wrong.I also noticed in #950 that it was mentioned that the warning was being removed, but I'm not sure whether that means it's suggested to declare parameters on the class directly or not.
Could you clarify what the recommended best practice for configuring these settings is now? Thanks!
The text was updated successfully, but these errors were encountered: