allow adding custom mime types while still using the module defaults

[bryangwilliam]

Pull Request (PR) description

Allows users to add custom mime types to mime.types without requiring them to manage the full list. It will append any custom types to the default list rather than completely overriding it.

This Pull Request (PR) fixes the following issues

n/a

[othalla]

This is a bit weird, why not explicitely specify all Mime types?
It is a bit weird to have additionals values while setting the $mime_types variable.
I prefer to have a second var like preserve_default_mime_types of something like that.

[bastelfreak]

I'm not sure if the merge approach is a good idea, this might confuse users. I agree with @othalla that this should be another variable or it should be handled in a profile.

[bryangwilliam]

To clarify, are you saying that you would prefer passing in the customizations in the normal parameter and then have a second parameter that triggers a merge with the defaults if requested? I agree that seems like a better approach and have no problem switching, just want to make sure I understand before I make the changes.

I'd prefer to avoid using a profile because that means I either need to forsake the defaults entirely or I need to include nginx::params to access the defaults which feels a little weird (I am currently using the approach and my attempt to clean that up is what initiated the PR). I'm not completely against the approach and could be convinced to keep using it if we can't find a good solution, but it does feel a little hacky.

[othalla]

Yep that's what i mean :)

[othalla]

This is better :) should be ok

[bastelfreak]

Thanks!