Add two more lingering_ config options #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nginx::config is a classBreaking changes to this file MAY impact these 2 modules (near match):nginx is a classBreaking changes to this file WILL impact these 14 modules (exact match):Breaking changes to this file MAY impact these 34 modules (near match):
This module is declared in 9 of 576 indexed public
|
|
The two failures for CentOS 6 seem to be due to the CentOS 6 base repo going away (http://mirror.centos.org/centos-6/6/readme) |
|
Once CI goes green on #1436 this PR can be rebased and testing here should also be good. |
sbeaulie
force-pushed
the
lingering_config
branch
from
2073b09
to
96c9d28
Compare
genebean
approved these changes
Jan 21, 2021
genebean
added
needs-work
bastelfreak
reviewed
Jan 21, 2021
See https://nginx.org/en/docs/http/ngx_http_core_module.html\#lingering_timeout tighten types for lingering_close list the 3 valid options as enum for lingering_time enforece a non empty string
sbeaulie
force-pushed
the
lingering_config
branch
from
96c9d28
to
e43790b
Compare
genebean
approved these changes
Jan 21, 2021
bastelfreak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Adding two more lingering_ config options
lingering_close
lingering_time
See https://nginx.org/en/docs/http/ngx_http_core_module.html#lingering_timeout
This Pull Request (PR) fixes the following issues
n/a