Do not set resource defaults on ssl_cert/ssl_key resources

[saz]

Pull Request (PR) description

With the merge of #1446 a change has been introduced, which changes permissions on the ssl_key and ssl_cert files.
This is due to resource defaults set in

puppet-nginx/manifests/resource/server.pp

Lines 438 to 447 in d51a170

	File {
	ensure => $ensure ? {
	'absent' => absent,
	default => 'file',
	},
	notify => Class['nginx::service'],
	owner => $owner,
	group => $group,
	mode => $mode,
	}

and the way, resource dependency is set up in e.g.

puppet-nginx/manifests/resource/server.pp

Lines 600 to 602 in d51a170

	File <| title == $key or path == $key |> {
	before => Concat::Fragment["${name_sanitized}-ssl-header"],
	}

If you're managing certificates and setting different owner and group, they will be changed to the user and group defined within this module, which isn't something expected.

This Pull Request (PR) fixes the following issues

None

[puppet-community-rangefinder]

nginx::resource::server is a type

Breaking changes to this file WILL impact these 13 modules (exact match):

• dhollinger-devopsdays
• kalfa-sites
• samuelson-custom_webapp
• akisakye-matomo
• othalla-nextcloud
• jonhallettuob-existdb
• aursu-dockerinstall
• ploperations-webhook_proxy
• aursu-gitlabinstall
• pgassmann-letsencrypt_nginx
• stackstorm-st2
• geoffwilliams-r_profile
• covata-safeshare

Breaking changes to this file MAY impact these 4 modules (near match):

• aursu-grayloginstall
• 4n0m4l0u5-configure_nginx
• qroac-isp3node
• mightp-librenms

This module is declared in 9 of 576 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.