Fix CI on CentOS 7 #1473
Merged
Fix CI on CentOS 7 #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without VirtualHost, nginx will start on CentOS but will not listen on any port. Add a sample VirtualHost using the default parameters so that the test suite can ensure port 80 is accepting connexions.
smortex
force-pushed
the
fix-ci-centos
branch
2 times, most recently
from
dd313d4
to
5b3d115
Compare
Merged
CentOS has a nginx-mod-mail package which should be installed when configuring nginx to process mail. On Debian, such packages are installed by the module and auto-lodaded but this mechanism is not in place for CentOS so we have to do it explicitely.
bastelfreak
approved these changes
Oct 2, 2021
|
This now appears to break things :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits fix CI on CentOS 7 🎉
Management of the mail module can be improved in multiple way, but for now I focused on fixing CI so I just ensure that what is not managed by the module and is required is properly setup in the regression test suite.
The configuration of the mail module in CI now match the configuration I have in place for passenger which the module does not handle on CentOS. We can probably improve this area in another PR to have the module able to have a similar behavior on CentOS and on Debian.